Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallel executions exceptions #1954

Merged
merged 2 commits into from
May 6, 2020
Merged

Fix parallel executions exceptions #1954

merged 2 commits into from
May 6, 2020

Conversation

scasteran
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

This MR prevents these 2 multi-thread related errors that happen randomly when running tests in parallel:

TechTalk.SpecFlow.SpecFlowException : Invalid sftemplate file! Duplicate key: 'CSharp/StepDefinitionRegex'.
   at TechTalk.SpecFlow.BindingSkeletons.FileBasedSkeletonTemplateProvider.EnsureInitialized()
System.NullReferenceException : Object reference not set to an instance of an object.
 TearDown : System.NullReferenceException : Object reference not set to an instance of an object.
    at TechTalk.SpecFlow.Infrastructure.ContextManager.InitializeScenarioContext(ScenarioInfo scenarioInfo)

@SabotageAndi
Copy link
Contributor

Thanks for this fix. Sorry that it took so long for me to review.
Could you rebase the PR on master and adjust the changelog?
Please add your entry under the Fixes for Development: section. Thanks!

Copy link
Contributor

@SabotageAndi SabotageAndi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase and adjust changelog please.

@scasteran
Copy link
Contributor Author

Sorry for the branch history. Hopefully this looks good now.

@SabotageAndi SabotageAndi merged commit 49b74c2 into SpecFlowOSS:master May 6, 2020
@SabotageAndi
Copy link
Contributor

Thanks for your contribution to SpecFlow. These flaky tests are very annoying.
If you would like us to send you some SpecFlow stickers as a thank you, please fill out the form here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants