Checkpoint - added notes from discussions with Jim about georeferenci…

…ng images, and design notes from work done last week

app/models/image.rb

@@ -88,6 +88,11 @@ def gps_data
     # Altitude should be based on reference of sea level
     # GPSAltitudeRef is 0 for above sea level, and 1 for below sea level
 
+    # From discussion with Jim -
+    # create a utility library called "GeoConvert" and define single method
+    # that will convert from degrees min sec to decimal degree
+    # - maybe 2 versions? - one returns string, other decimal?
+
   end
 
   protected

app/models/serial.rb

@@ -23,48 +23,60 @@ class Serial < ActiveRecord::Base
   has_many :preceding_serials, through: :serial_chronologies_as_object, class_name: 'Serial'
 
   # Scopes, clustered by function
+  # select all serials with this name
+  # select all serials with this abbreviation
+  # select all serials with this translation name
+  # select all serials that match this name or alternate value
 
   # "Hard" Validations
   validates_presence_of :name
+  # TODO validate language
 
   # "Soft" Validations
   soft_validate(:sv_duplicate?)
 
   # Getters/Setters
+  # TODO set language via string name
 
   # Class methods
 
   # Instance methods
   def duplicate?
     # Boolean is there another serial with the same name?
+    ret_val = false
     if self.new_record?
-      Serial.exists?(name: self.name)
+      ret_val = Serial.exists?(name: self.name)
     else
-      # where{ geographic_items.flatten.collect { |geographic_item| "id != #{geographic_item.id}" }.join(' and ')}
-=begin
-        f = select { '*' }.
-          select_distance(column_name, geographic_item).
-          where_distance_greater_than_zero(column_name,geographic_item).
-          order { 'distance desc' }
-
-select { "ST_Distance(#{column_name}, GeomFromEWKT('srid=4326;#{geographic_item.geo_object}')) as distance" }
-
-=end
-      dup = Serial.where("name = ? AND id <> ?", self.name, self.id).to_a
-      # select { "name = #{self.name} AND NOT (id = #{self.id})"}
-      dup
+      ret_val = Serial.where( "name = '#{self.name}' AND NOT (id = #{self.id})").to_a.count > 0
     end
 
+    ret_val # return
   end
+
+  def previous_serial
+    # return previous serial object or nil
+  end
+
+  def succeeding_serial
+    # return succeeding serial object or nil
+  end
+
+  def chronology
+    # return ordered array of serials associated with this serial
+  end
+
   protected
 
 
   def sv_duplicate?
     if self.duplicate?
       soft_validations.add(:name, 'There is another serial with this name in the database.')
     end
+    # TODO soft validation of name matching an alternate value for name of a different serial
   end
 
-  # TODO soft validation of name matching an alternate value for name of a different serial
+  def match_alternate_value?
+    #Select value from AlternateValue WHERE alternate_object_type = 'Serial' AND alternate_object_attribute = 'name'
 
+  end
 end

app/models/source/bibtex.rb

@@ -342,6 +342,7 @@ def to_bibtex # outputs BibTeX::Entry equivalent to me.
     end
 
     # TODO add conversion of identifiers to ruby-bibtex fields, & notations to notes field.
+    # TODO add conversion of Serial ID to journal name
 
     b.key = self.id
     b
@@ -403,6 +404,8 @@ def self.bibtex_author_to_person(bibtex_author)
         suffix:     bibtex_author.suffix)
   end
 
+  #TODO create related Serials
+
 #endregion  ruby-bibtex related
 
 #region getters & setters

spec/models/image_spec.rb

@@ -51,7 +51,7 @@
     expect(j.has_duplicate?).to be_true
     image_array = j.duplicate_images
     expect(image_array.count).to eq(2)
-    expect(image_array.sort).to eq([@i,k].sort)
+    expect(image_array.sort).to eq([@i, k].sort)
 
     j.soft_validate
     expect(j.soft_validations.messages).to include 'This image is a duplicate of an image already stored.'
@@ -99,9 +99,13 @@
     expect(File.exists?(Rails.root.to_s + Image::MISSING_IMAGE_PATH)).to be_true
   end
 
-  specify 'exif data should be available if it was provided in the original image' do
+  specify 'exif data should be available if it was provided in the image' do
     # return empty hash when no EXIF data present
     # return correct EXIF data on following images:
+    #   Samsung phone - Samsung_Phone.jpg
+    #   Exif added later - post_processed.jpg
+    #   Exif with comments
+    #   Exif with edited data
 
   end
 

spec/models/serial_spec.rb

@@ -37,16 +37,18 @@
     expect(k.soft_validations.messages_on(:name).empty?).to be_false
     expect(k.soft_validations.messages).to include 'There is another serial with this name in the database.'
 
+    # TODO 'should check for duplicate between name & other serial tags'
+    # create alternate value/types synonym, translation, abbreviation
   end
   it 'should set the language based on valid languages' do
-    pending 'not implemented yet'
+    pending 'no languages in the language table yet'
   end
 
   it 'should use English as the default language' do
     pending 'is this true?'
   end
 
-
+  it 'should list the Serial Chronology'
 
   it 'should list all preceding serials' do
     pending 'not implemented yet'

spec/models/source/bibtex_spec.rb

@@ -118,6 +118,7 @@
       expect(@s.to_bibtex.fields).to eq(@gem_bibtex_entry1.fields)
       expect(@s.bibtex_type.to_s).to eq(@gem_bibtex_entry1.type.to_s)
       pending 'test that notes gets converted properly to a bibtex note'
+      # TODO test serial gets converted properly to bibtex journal
     end
 
     specify 'valid_bibtex?' do
@@ -511,6 +512,8 @@
         end
 
       end
+
+      # TODO if the bibtex entry has a journal create the Serials
     end
 
     %w{author editor}.each do |a|