Fix #1737

SpeciesFileGroup · Nov 2, 2020 · d3b7a29 · d3b7a29
1 parent f30cf8d
commit d3b7a29
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -23,8 +23,9 @@ This project <em>does not yet</em> adheres to [Semantic Versioning](https://semv
 
 ### Changed
 - Running `rake db:seed` without `user_id`/`project_id` is now possible.
+- Disabled hamburger menu when no functionality behind it on Browse OTU [#1737]
 
-
+[#1737]: https://github.com/SpeciesFileGroup/taxonworks/issues/1737
 [#1865]: https://github.com/SpeciesFileGroup/taxonworks/issues/1865
 [#1822]: https://github.com/SpeciesFileGroup/taxonworks/issues/1822
 [#1846]: https://github.com/SpeciesFileGroup/taxonworks/issues/1846

diff --git a/app/javascript/vue/tasks/otu/browse/components/AssertedDistribution.vue b/app/javascript/vue/tasks/otu/browse/components/AssertedDistribution.vue
@@ -3,6 +3,7 @@
     :status="status"
     :spinner="loadState.assertedDistribution"
     :title="title"
+    menu
     @menu="setModalView(true)">
     <a
       v-if="currentOtu"

diff --git a/app/javascript/vue/tasks/otu/browse/components/BiologicalAssociations.vue b/app/javascript/vue/tasks/otu/browse/components/BiologicalAssociations.vue
@@ -3,6 +3,7 @@
     :status="status"
     :title="title"
     :spinner="loadState.biologicalAssociations"
+    menu
     @menu="setModalView(true)">
     <a name="biological-associations"/>
     <table class="full_width">

diff --git a/app/javascript/vue/tasks/otu/browse/components/NomenclatureHistory.vue b/app/javascript/vue/tasks/otu/browse/components/NomenclatureHistory.vue
@@ -3,6 +3,7 @@
     :status="status"
     :title="title"
     :spinner="isLoading"
+    menu
     @menu="showModal = true">
     <a name="timeline"/>
     <div class="switch-radio separate-top separate-bottom">

diff --git a/app/javascript/vue/tasks/otu/browse/components/descendants.vue b/app/javascript/vue/tasks/otu/browse/components/descendants.vue
@@ -3,6 +3,7 @@
     :spinner="isLoading"
     :status="status"
     :title="title"
+    menu
     @menu="showModal = true">
     <a name="descendants"/>
     <tree-view

diff --git a/app/javascript/vue/tasks/otu/browse/components/shared/sectionPanel.vue b/app/javascript/vue/tasks/otu/browse/components/shared/sectionPanel.vue
@@ -20,8 +20,11 @@
           data-icon="w_scroll-v"
           class="option-box button-default cursor-pointer handle"
         />
-        <div
-          class="option-box button-default cursor-pointer"
+        <button
+          type="button"
+          class="option-box cursor-pointer"
+          :class="{ 'button-default': menu }"
+          :disabled="!menu"
           v-help.section.options.filter
           @click="$emit('menu')"
         >
@@ -30,7 +33,7 @@
             <div class="hamburger-menu-bar" />
             <div class="hamburger-menu-bar" />
           </div>
-        </div>
+        </button>
       </div>
     </div>
     <div class="content">
@@ -61,6 +64,10 @@ export default {
     anchor: {
       type: String,
       default: undefined
+    },
+    menu: {
+      type: Boolean,
+      default: false
     }
   },
   data () {
@@ -80,6 +87,7 @@ export default {
     padding: 0px;
     background-position: center;
     background-size: 14px;
+    border: 0px;
   }
   .hamburger-menu {
     position: absolute;