Adds generic RecordNotFound 404 handling on raises in controllers (Ap…

…plicationController). Modifies the search pattern, again, for default ajax selectors.

app/controllers/application_controller.rb

@@ -2,6 +2,7 @@ class ApplicationController < ActionController::Base
   # Prevent CSRF attacks by raising an exception.
   # For APIs, you may want to use :null_session instead.
   protect_from_forgery with: :exception
+  rescue_from ActiveRecord::RecordNotFound, with: :record_not_found
 
   include Workbench::SessionsHelper
   include ProjectsHelper
@@ -65,5 +66,11 @@ def meta_data
   def site_name
     @site_name ||= 'TaxonWorks'
   end
+
+  private
+
+   def record_not_found
+     render plain: "404 Not Found", status: 404
+   end
 
 end

app/controllers/concerns/data_controller_configuration/project_data_controller_configuration.rb

@@ -2,8 +2,7 @@ module DataControllerConfiguration::ProjectDataControllerConfiguration
   extend ActiveSupport::Concern
 
   included do
-  include DataControllerConfiguration
-
+    include DataControllerConfiguration
     before_action :require_sign_in_and_project_selection
   end
 

app/controllers/images_controller.rb

@@ -75,8 +75,6 @@ def search
     end
   end
 
-
-
   def autocomplete
     @images = Image.find_for_autocomplete(params.merge(project_id: sessions_current_project_id)) # in model
 

app/views/collecting_events/_quick_search_form.html.erb

@@ -1,4 +1,4 @@
-<%= form_tag(search_collecting_events_path) do %>
+<%= form_tag(search_collecting_events_path, {method: :get}) do %>
     <%= render partial: 'workbench/elements/forms/ajax_select',
                locals:  {controller: 'collecting_events',
                          object:     nil,

app/views/collection_objects/_quick_search_form.html.erb

@@ -1,4 +1,4 @@
-<%= form_tag(search_collection_objects_path) do %>
+<%= form_tag(search_collection_objects_path, {method: :get}) do %>
     <%= render partial: 'workbench/elements/forms/ajax_select',
                locals:  {controller: 'collection_objects',
                          object:     nil,

app/views/contents/_quick_search_form.html.erb

@@ -1,4 +1,4 @@
-<%= form_tag(search_contents_path) do %>
+<%= form_tag(search_contents_path, {method: :get}) do %>
     <%= render partial: 'workbench/elements/forms/ajax_select',
                locals:  {controller: 'contents',
                          object:     nil,

app/views/controlled_vocabulary_terms/_quick_search_form.html.erb

@@ -1,4 +1,4 @@
-<%= form_tag(search_controlled_vocabulary_terms_path) do %>
+<%= form_tag(search_controlled_vocabulary_terms_path, {method: :get}) do %>
     <%= render partial: 'workbench/elements/forms/ajax_select',
                locals:  {controller: 'controlled_vocabulary_terms',
                          object:     nil,

app/views/geographic_areas/_quick_search_form.html.erb

@@ -1,4 +1,4 @@
-<%= form_tag(search_geographic_areas_path) do %>
+<%= form_tag(search_geographic_areas_path, {method: :get}) do %>
     <%= render partial: 'workbench/elements/forms/ajax_select',
                locals:  {controller: 'geographic_areas',
                          object:     nil,

app/views/images/_quick_search_form.html.erb

@@ -1,4 +1,4 @@
-<%= form_tag(search_images_path) do %>
+<%= form_tag(search_images_path, {method: :get}) do %>
     <%= render partial: 'workbench/elements/forms/ajax_select',
                locals:  {controller: 'images',
                          object:     nil,

app/views/loans/_quick_search_form.html.erb

@@ -1,4 +1,4 @@
-<%= form_tag(search_loans_path) do %>
+<%= form_tag(search_loans_path, {method: :get}) do %>
     <%= render partial: 'workbench/elements/forms/ajax_select',
                locals:  {controller: 'loans',
                          object:     'loan',

app/views/namespaces/_quick_search_form.html.erb

@@ -1,4 +1,4 @@
-<%= form_tag(search_namespaces_path) do %>
+<%= form_tag(search_namespaces_path, {method: :go}) do %>
     <%= render partial: 'workbench/elements/forms/ajax_select',
                locals:  {controller: 'namespaces',
                          object:     nil,

app/views/otus/_quick_search_form.html.erb

@@ -1,4 +1,4 @@
-<%= form_tag(search_otus_path) do %>
+<%= form_tag(search_otus_path, {method: :get}) do %>
     <%= render partial: 'workbench/elements/forms/ajax_select',
                locals:  {controller: 'otus',
                          object:     nil,

app/views/people/_quick_search_form.html.erb

@@ -1,4 +1,4 @@
-<%= form_tag(search_people_path) do %>
+<%= form_tag(search_people_path, {method: :get}) do %>
     <%= render partial: 'workbench/elements/forms/ajax_select',
                locals:  {controller: 'people',
                          object:     nil,

app/views/projects/_quick_search_form.html.erb

@@ -1,4 +1,4 @@
-<%= form_tag(search_projects_path) do %>
+<%= form_tag(search_projects_path, {method: :get}) do %>
     <%= render partial: 'workbench/elements/forms/ajax_select',
                locals:  {controller: 'projects',
                          object:     nil,

app/views/repositories/_quick_search_form.html.erb

@@ -1,4 +1,4 @@
-<%= form_tag(search_repositories_path) do %>
+<%= form_tag(search_repositories_path, {method: :get}) do %>
     <%= render partial: 'workbench/elements/forms/ajax_select',
                locals:  {controller: 'repositories',
                          object:     nil,

app/views/sources/_quick_search_form.html.erb

@@ -1,4 +1,4 @@
-<%= form_tag(search_sources_path) do %>
+<%= form_tag(search_sources_path, {method: :get}) do %>
     <%= render partial: 'workbench/elements/forms/ajax_select',
                locals:  {controller: 'sources',
                          object:     nil,

app/views/tags/_quick_search_form.erb

@@ -1,4 +1,4 @@
-<%= form_tag(search_tags_path) do %>
+<%= form_tag(search_tags_path, {method: :get}) do %>
     <%= render partial: 'workbench/elements/forms/ajax_select',
                locals:  {controller: 'tags',
                          object:     nil,

app/views/taxon_names/_quick_search_form.erb

@@ -1,4 +1,4 @@
-<%= form_tag(search_taxon_names_path) do %>
+<%= form_tag(search_taxon_names_path, method: :get) do %>
     <%= render partial: 'workbench/elements/forms/ajax_select',
                locals:  {controller: 'taxon_names',
                          object:     nil,

app/views/type_materials/_quick_search_form.html.erb

@@ -1,4 +1,4 @@
-<%= form_tag(search_type_materials_path) do %>
+<%= form_tag(search_type_materials_path, {method: :get}) do %>
     <%= render partial: 'workbench/elements/forms/ajax_select',
                locals:  {controller: 'type_materials',
                          object:     nil,

config/routes.rb

@@ -1,6 +1,5 @@
 TaxonWorks::Application.routes.draw do
 
-  # Vetted / tested
 
   # All models that use data controllers should include this concern. 
   # See http://api.rubyonrails.org/classes/ActionDispatch/Routing/Mapper/Concerns.html to extend it to take options if need be.
@@ -11,8 +10,8 @@
       get 'list'
       post 'batch_create'
       post 'batch_preview'
-      post 'search'
       get 'autocomplete'
+      get 'search'
     end
   end
 
@@ -224,4 +223,5 @@
   #     # (app/controllers/admin/products_controller.rb)
   #     resources :products
   #   end
+  #
 end