Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CO Match to return items from loan #3387

Closed
tmcelrath opened this issue Apr 25, 2023 · 12 comments
Closed

Use CO Match to return items from loan #3387

tmcelrath opened this issue Apr 25, 2023 · 12 comments
Labels
enhancement Suggest an improvement to an existing function.

Comments

@tmcelrath
Copy link

Feature or enhancement

I would like to use Collection Object Match not just to add objects to a loan, but also to return them.
Use the same format as in Edit Loans.
Select all matched collection objects, mark as any of the loan statuses, and also add date.

Location

Collection object match

Screenshot, napkin sketch of interface, or conceptual description

image

Your role

Collection manager

@tmcelrath tmcelrath added the enhancement Suggest an improvement to an existing function. label Apr 25, 2023
@tmcelrath
Copy link
Author

@mjy any chance we can add this by next release? I have a spreadsheet with over 2000+ catalog numbers I do NOT want to return/click one by one.

@mjy
Copy link
Member

mjy commented Apr 25, 2023

@tmcelrath not by the next minor release, sorry, but we can try and get this integrated into the CO filter (a new loan radial) soonish.

@tmcelrath
Copy link
Author

Do we want this in CO filter or CO match? Or are they getting merged? I would prefer in CO match right now.

@mjy
Copy link
Member

mjy commented Apr 25, 2023

CO filter has match (most filters do now)

Imagine in CO filter a new radial with slices to add/return etc. objects to some loan. A far more poweful way to select and deal with specimen/loan relationships I think?

@tmcelrath
Copy link
Author

Ah, cool. Yeah, that would work.

@mjy
Copy link
Member

mjy commented Apr 25, 2023

I'm envision batch updates to objects in other ways merging to filter, or at least originating in filter when more complex.

@tmcelrath
Copy link
Author

Just as a comparison @mjy , it took me four hours to return items from a large loan from a spreadsheet where I had all the numbers available, vs. 2 minutes to add those numbers to a new loan. This is ABSOLUTELY a priority for me now.

@tmcelrath
Copy link
Author

That was for ~300 numbers. I have ~2000 in an upcoming returned loan to do next. By that logic returning the loan will take ~27 hoursish :0

@mjy
Copy link
Member

mjy commented Apr 28, 2023

I can't believe you let it run for 4 hours :). Something definitely wrong there. Not suprising as Filter CO conects a ton of things, but that latency suggests big problem with the underlying query.

@tmcelrath
Copy link
Author

No no. There is no way to do it automatically. That's me doing it manually.

I'm just comparing the automatic adding things to loans vs. the manual removing things from loans.

@tmcelrath
Copy link
Author

So, adding, automatic, with identifier matching = 2 minutes.
So removing, manual, clicking over 300 objects and comparing them to two different spreadsheets = 4 hours.

Need an automatic way to remove from a loan given a set of catalog numbers.

@mjy
Copy link
Member

mjy commented May 4, 2023

Radial.

3 Slices.

  • Add
  • Return
  • Return and add

Inputs: (params are all the same as used in loan_items)

Add

  • POST /loan_items/batch_create
  • Loan (autocomplete to loan, or smart selector if available)

Return

  • POST /loan_items/batch_return
  • Status (same as loan item row)
  • Date returned (with button to set for "Now")

Return and add

  • POST /loan_items/batch_move

2 sections (basically we are returning from one loan AND adding the returned to a loan)

  1. "Return"
  • Status (same as loan item row)
  • Date returned (with button to set for "Now")
  1. "Add"
  • Loan (autocomplete to loan, or smart selector if available)

All forms include typed confirmation after green button clicked (Add, Return, Return and add)

post :batch_return
post :batch_move

@mjy mjy closed this as completed in a0313cf May 5, 2023
mjy added a commit that referenced this issue May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Suggest an improvement to an existing function.
Projects
None yet
Development

No branches or pull requests

2 participants