Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZonalRidge orography added, Geometry with lond,latd #223

Merged
merged 4 commits into from
Jan 12, 2023
Merged

Conversation

milankl
Copy link
Member

@milankl milankl commented Jan 10, 2023

No description provided.

@milankl milankl added structure 🏠 Internal structure of the code dynamics 〰️ Affects the dynamical core labels Jan 10, 2023
@milankl milankl added this to the v0.5 milestone Jan 10, 2023
@milankl milankl requested a review from dmey January 10, 2023 19:35
@milankl
Copy link
Member Author

milankl commented Jan 10, 2023

@dmey the lat,lon in ColumnVariables was pulled from Geometry, but it turned out they were actually colatitudes and longitudes in radians, not latitude and longitudes. I've changed those to be consistently latitudes and longitudes in ˚N,˚E and therefore also swapped cos,sin to cosd,sind. However, now there are a bunch of tests failing in shortwave radiation. Could you check what's going on there?

@dmey
Copy link
Contributor

dmey commented Jan 11, 2023

@milankl sure--mind if I look at the weekend?

@milankl
Copy link
Member Author

milankl commented Jan 11, 2023

Absolutely no problem. For now I'll set the tests to breaking, and merge, then you can check what's going on whenever you got time for this. In general I found tests that are formulated as exact as yours less helpful than more qualitative checks. E.g. you check the results to an accuracy that's many orders of magnitude higher than what we require for the spectral transforms, although they have some exact mathematics in the continuous limit behind them! I've spent to much time in the last year updating tests because they were formulated unnecessarily precise. Given that SpeedyWeather isn't mature nor it's structure very stable yet I'd go for more qualitatitive tests, meaning tests that immediately flag if things go horribly wrong. Does that make sense?

@milankl milankl merged commit 7d57282 into main Jan 12, 2023
@milankl milankl deleted the mk/orography branch January 12, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dynamics 〰️ Affects the dynamical core structure 🏠 Internal structure of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants