Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New normalization for automatic sigma levels #245

Merged
merged 2 commits into from
Feb 7, 2023
Merged

New normalization for automatic sigma levels #245

merged 2 commits into from
Feb 7, 2023

Conversation

milankl
Copy link
Member

@milankl milankl commented Feb 7, 2023

fixes #228

@milankl milankl added bug 🐞 Something isn't working vertical ⬆️ Affecting the vertical dimension labels Feb 7, 2023
@milankl milankl added this to the v0.5 milestone Feb 7, 2023
@milankl
Copy link
Member Author

milankl commented Feb 7, 2023 •
edited
Loading

@dmey sorry, I have to @test_skip more radiation tests. Here I just changed the position of the vertical levels slightly (which is already different from Fortran speedy anyway, see #22), which causes tests to fail.

   Expression: column.ftop ≈ 474.76064406
   Evaluated: 474.0794f0 ≈ 474.76064406

@milankl milankl merged commit 81d2eba into main Feb 7, 2023
@milankl milankl deleted the mk/vertical branch February 7, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐞 Something isn't working vertical ⬆️ Affecting the vertical dimension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not more than 70 vertical levels
1 participant
@milankl