Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boundary layer scheme from Held and Suarez #269

Merged
merged 6 commits into from
Mar 27, 2023
Merged

Boundary layer scheme from Held and Suarez #269

merged 6 commits into from
Mar 27, 2023

Conversation

milankl
Copy link
Member

@milankl milankl commented Mar 27, 2023

This introduces the simple boundary layer scheme from Held and Suarez

image

and also introduces abstract type BoundaryLayer end with

struct NoBoundaryLayer end
struct LinearDrag ... end

such that run_speedy(boundary_layer=NoBoundaryLayer()) switches it off but

run_speedy(boundary_layer=LinearDrag(kwargs...))

uses that scheme and in general one can pass on any struct <: BoundaryLayer when also defining boundary_layer!(column,::MyBoundaryLayer,model) to introduce a new scheme.

@white-alistair this is the first time the parameterization_tendencies! loop actually runs through and executes things, but other schemes are currently commented. I want to test them one by one.

@milankl milankl added parallel 🐎 Things being computed in parallel parameterizations 🌧️ Parameterizations of unresolved physical processes labels Mar 27, 2023
@milankl milankl added this to the v0.5 milestone Mar 27, 2023
@milankl milankl merged commit 12fd32e into main Mar 27, 2023
@white-alistair
Copy link
Member

@milankl testing the parameterisations one by one also seems like the right time to refactor them. I think @dmey and I took quite different yet complementary approaches, which I like, and it would be good to keep the best of both.

@milankl
Copy link
Member Author

milankl commented Mar 29, 2023

Yes, please let me know if you have any opinion on "best of both".

@milankl milankl mentioned this pull request Mar 30, 2023
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parallel 🐎 Things being computed in parallel parameterizations 🌧️ Parameterizations of unresolved physical processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants