Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedstring precompilation warning #369

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Speedstring precompilation warning #369

merged 2 commits into from
Aug 30, 2023

Conversation

milankl
Copy link
Member

@milankl milankl commented Aug 30, 2023

fixes #296 by "extending" the speedstring method just with a bit more specific ::AbstractFloat dispatch (in ProgressMeter it's ::Any) not through overwriting

It seems to work

(@v1.9) pkg> add https://github.com/SpeedyWeather/SpeedyWeather.jl#mk/speedstring
    Updating git-repo `https://github.com/SpeedyWeather/SpeedyWeather.jl`
   Resolving package versions...
    Updating `~/.julia/environments/v1.9/Project.toml`
  [9e226e20] + SpeedyWeather v0.5.0 `https://github.com/SpeedyWeather/SpeedyWeather.jl#mk/speedstring`
    Updating `~/.julia/environments/v1.9/Manifest.toml`
  [9e226e20] + SpeedyWeather v0.5.0 `https://github.com/SpeedyWeather/SpeedyWeather.jl#mk/speedstring`
Precompiling project...
  1 dependency successfully precompiled in 17 seconds. 313 already precompiled

@milankl milankl added bug 🐞 Something isn't working dependency 🦮 Dependencies on other packages labels Aug 30, 2023
@milankl milankl added this to the v0.6 milestone Aug 30, 2023
@milankl milankl merged commit 1564fe9 into main Aug 30, 2023
4 checks passed
@milankl milankl deleted the mk/speedstring branch August 30, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working dependency 🦮 Dependencies on other packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precompilation warnings?
1 participant