Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tendencies structure #39

Merged
merged 10 commits into from
Mar 30, 2022
Merged

Update tendencies structure #39

merged 10 commits into from
Mar 30, 2022

Conversation

tomkimpson
Copy link
Collaborator

Some changes and tests to make tendencies calculations fully consistent and tested.

Work in progress - draft PR

@tomkimpson tomkimpson self-assigned this Feb 24, 2022
@tomkimpson
Copy link
Collaborator Author

Notes:

  • Need to establish clearly which are spectral quantities and which are grid point quantities
  • Some additional parameters defined in geometry.jl (e.g. tref,rgas). Currently not defined correctly - just in place for structure.

@tomkimpson tomkimpson mentioned this pull request Feb 26, 2022
Closed
@tomkimpson tomkimpson linked an issue Feb 26, 2022 that may be closed by this pull request
Consistent definition of model #42
Closed
@tomkimpson tomkimpson mentioned this pull request Mar 29, 2022
Closed
@tomkimpson tomkimpson marked this pull request as ready for review March 29, 2022 12:54
@tomkimpson tomkimpson merged commit 5873d5f into main Mar 30, 2022
@milankl milankl deleted the TK/unit_tests_tendencies branch January 12, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tomkimpson tomkimpson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistent definition of model
1 participant
@tomkimpson