Adjust time step with radius #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Galewsky jet after 4 days on Mars (radius=3.39e6) 
Galewsky jet after 4 days on a planet 4x Earth's radius 
However, at the moment larger planets cause stability problems, not sure why: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the time step was automatically chosen as a function of resolution but not as a function of radius, but larger planets have effectively a coarser grid spacing, meaning they can deal with larger time steps. And vice versa: radius=1e6 currently blows up in the shallow water model because we effectively have a finer resolution by a factor of ~7x, which requires a ~7x smaller time step.
As suggested by @KristianJS