-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Models - RcCollectionRaw and RcCollection #131
Conversation
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
+ Coverage 82.17% 86.51% +4.34%
==========================================
Files 27 31 +4
Lines 387 445 +58
==========================================
+ Hits 318 385 +67
+ Misses 69 60 -9
Continue to review full report at Codecov.
|
RcCollectionRaw is a model that to get a list of paths with blueprintrc files that exist. It processes files from:
The paths are tested to be sure that they exist and are files |
|
blueprintrc files may have
because I hate not being able to comment config files |
This class creates an ordered list of rc files that will be read. It uses the BLUEPRINT_CONFIG env variable to add files to the default search paths.
Returns an object deep merged from all files. Arrays are joined as well.
Looks good. The CLI is currently configured to look for Suspect we need platform specific path separators rather than just using colon:
|
I'll leave it to the cli to deal with the ENV then. Is that true for other options passed via ENV as well? I'd be happy to just accept an obj containing the parsed structure and values, is that possible? I'll remove my code that deals with that. I've been assuming that the CLI had top priority, and that ENV had 2nd. . Ahem, do we need a different path separator? It's not something the shell would use, so does it matter to us? Not sure. |
Refactored into #132. Closing this earlier draft unmerged. |
This class creates an ordered list of rc files that will be read.
It uses the BLUEPRINT_CONFIG env variable to add files to the default
search paths.
WIP