Get rid of useless abstract process duplicate classes #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed when cleaning up the Java code that we had a plethora of nearly-unused abstract process things. This is the start of getting rid of all of that!
It now only had one subclass. I'd have got rid of the subclass and used the name of the superclass instead, except that the subclass has references to it in SpiNNFrontEndCommon
dkfellows
added a commit
to SpiNNakerManchester/IntegrationTests
that referenced
this pull request
Oct 19, 2022
rowleya
approved these changes
Oct 21, 2022
This was referenced Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when cleaning up the Java code (SpiNNakerManchester/JavaSpiNNaker#609) that we had a plethora of nearly-unused abstract process things, and reasoned that we had them in SpiNNMan too (because the comms in the Java code started as a direct clone of it). This is the start of getting rid of all of that!