C version of router compressor with bit field #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ock of the code. variables renamed. etc. lots of dcumentation. etc etce tc
Pull Request Test Coverage Report for Build 761
💛 - Coveralls |
dkfellows
requested changes
Apr 25, 2019
unittests/test_exec_finder.py
Outdated
| ef.get_executable_path("abc.aplx") | ||
| return False | ||
| except Exception: | ||
| return True |
There was a problem hiding this comment.
This is not how you assert that an exception happened!
unittests/test_exec_finder.py
Outdated
| ef.get_executable_path("abc.aplx") | ||
| return False | ||
| except Exception: | ||
| return True |
There was a problem hiding this comment.
This is not how you assert that an exception happened!
unittests/test_progress_bar.py
Outdated
| p = pbclass(2, None) | ||
| with pytest.raises(Exception): |
There was a problem hiding this comment.
This is (was) how you assert that an exception is thrown.
|
The early exploding executable finder is reasonable. I look forward to approving this PR once the testing is meaningful. |
|
(Default ordered dicts have gone in via separate PR, #81) |
Christian-B
approved these changes
Apr 25, 2019
|
fixed ready for someone to merge |
Christian-B
requested changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a default ordered dict and made the executable finder explode earlier.