Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultOrderedDict #81

Merged
merged 2 commits into from
Apr 25, 2019
Merged

DefaultOrderedDict #81

merged 2 commits into from
Apr 25, 2019

Conversation

Christian-B
Copy link
Member

Combine default dict and orderedDict

@Christian-B Christian-B added this to the 5.0.0 milestone Apr 24, 2019
@coveralls
Copy link

coveralls commented Apr 24, 2019 •
edited

Pull Request Test Coverage Report for Build 724

  • 24 of 34 (70.59%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 91.622%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spinn_utilities/ordered_default_dict.py 24 34 70.59%
Totals Coverage Status
Change from base Build 706: -0.3%
Covered Lines: 2056
Relevant Lines: 2244
💛 - Coveralls

@Christian-B Christian-B mentioned this pull request Apr 24, 2019
Merged
@dkfellows
Copy link
Member

I like that this may reduce the amount of monkey business with import magic in the rest of our code.

@dkfellows dkfellows merged commit 8cfd3f6 into master Apr 25, 2019
@dkfellows dkfellows deleted the order branch April 25, 2019 12:42
@dkfellows dkfellows mentioned this pull request Apr 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkfellows dkfellows dkfellows approved these changes

Assignees

@dkfellows dkfellows

Labels
enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Christian-B @coveralls @dkfellows