NullPointerException when deserializing 1.16 window title components via bungeecord-chat

[Exceptionflug]

The current reference implementation of the 1.16 minecraft server produces window title chat components that are declaring a click event without any value property in it. This will cause a NullPointerException since there is so null check to ensure that the specific value key is present in that JSON object. See: https://github.com/SpigotMC/BungeeCord/blob/master/chat/src/main/java/net/md_5/bungee/chat/BaseComponentSerializer.java#L68
The minecraft client is fine with that circumstances. BungeeCord should also be.

Referenced issue where this exception is a problem: Exceptionflug/protocolize#46

[Exceptionflug]

@md-5 @Janmm14 this needs to be fixed soon.

[Mystiflow]

Possible fix: https://github.com/SpigotMC/BungeeCord/blob/master/chat/src/main/java/net/md_5/bungee/chat/BaseComponentSerializer.java#L68

changed to ( event.has( "value" ) ) ? event.get( "value" ).getAsString() ) : ""; would use an empty string as the fallback instead of null as I assume most plugins wouldn't check that

[Exceptionflug]

Yes this would fix the NullPointerException.

[Mystiflow]

Just wondering; have you been able to locate where the NMS (or wherever else) is making these window titles without the value?

[Exceptionflug]

Currently not since I don't have access to nms 1.16 code