Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow
export_to_phy
to work withfast_templates
#2549Allow
export_to_phy
to work withfast_templates
#2549Changes from 9 commits
91c1105
df67578
31f98d6
f573c61
faf1735
1217184
3f82ba1
2611adc
3d52dee
1095f9a
6b77697
4f7f15f
44de825
a63d7a0
645837e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about this and
templates_ext
cannot be None, because if it is None above thetemplates_ext.get_templates
will fail. Or am I misreading this? It seems to me that it would be better to do a check for none after line 185. Something likeThat way regardless of if the
|
notation is accepted you have the check in place.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, nice catch!
But as you said, I'm waiting for the
|
PR to be merged, to re-write this more cleanly :)