Fix channel gains in NwbRecordingExtractor with backend
#2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires #2665 |
alejoe91
approved these changes
Apr 4, 2024
|
Could we try limiting pytest to < 8 and see if that fixes this PR? (based on @h-mayorquin and my discussion I think that is worth a try to see if this is a pytest collection issue). If that fixes this test then the decision would be to permanently limit pytest or rewrite the action and see if that fixes this. |
|
@zm711 the problem was that scipy did not have an upper bound and ibllib was throwing this error when importing. This illustrate a problem with the non-specificty of the try-except block. It took me a while to discover what was causing it exactly . |
|
Cool! As long as you got it! |
|
Yeah, it is good to be aware that there might be something broken in pytest. Let's keep an eye on that. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the reading of the
channel_conversionto gains in the backend is not working. The reason is that this is written as a dataset and not an attribute the way that the current function assumes.This PR adds a test that fails with the current state of the repo and also the changes that fix this.
I detected this while working on a neuroconv issue:
catalystneuro/neuroconv#803