Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update detect_bad_channels docs #2783

Merged
merged 2 commits into from
May 1, 2024
Merged

Conversation

RobertoDF
Copy link
Contributor

@RobertoDF RobertoDF commented Apr 29, 2024

Clarify that detect_bad_channels doesn´t automatically deal with multi probe recordings #2766

@zm711
Copy link
Collaborator

zm711 commented Apr 30, 2024

I want to double check if this should really be on a per-shank basis (some probes are multishank) otherwise I think we may want to mention that if you have multi probes (e.g. in a probegroup). @alejoe91 @samuelgarcia ?

Once I know which is more correct I'm happy to point out where exactly I would add the extra clarification. Otherwise I think this is a nice addition :)

@zm711
Copy link
Collaborator

zm711 commented Apr 30, 2024

Fixes #2766
Also one tiny thing @RobertoDF if you put fixes xx like I did here it will auto link the issue and close it when the PR is merged. It helps with housekeeping :)

@alejoe91 alejoe91 added documentation Improvements or additions to documentation preprocessing Related to preprocessing module labels Apr 30, 2024
Co-authored-by: Alessio Buccino <alejoe9187@gmail.com>
@alejoe91 alejoe91 merged commit 9e3c9b8 into SpikeInterface:main May 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation preprocessing Related to preprocessing module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants