Add typing to write_binary_recording
#2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
zm711
reviewed
May 6, 2024
alejoe91
reviewed
May 10, 2024
| @@ -110,8 +110,7 @@ def write_binary_recording( | |||
| file_path_list = [add_suffix(file_path, ["raw", "bin", "dat"]) for file_path in file_path_list] | |||
|
|
|||
| dtype = dtype if dtype is not None else recording.get_dtype() | |||
| cast_unsigned = False | |||
| if auto_cast_uint: | |||
| if auto_cast_uint: # TODO should we deprecate this given that we have `unsigned_to_signed`? | |||
There was a problem hiding this comment.
@h-mayorquin can you add it to this PR?
There was a problem hiding this comment.
I also improved the docstrings a little bit.
There was a problem hiding this comment.
The docstring looks nicer to me :)
alejoe91
reviewed
May 10, 2024
Co-authored-by: Alessio Buccino <alejoe9187@gmail.com>
alejoe91
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on the tutorial. Small PR with improvement.