Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin matplotlib dependency #2866

Merged

Conversation

h-mayorquin
Copy link
Collaborator

Should fix #2863 while someone goes and ensures that the library works with the newest version of matplotlib

@h-mayorquin h-mayorquin added dependencies Issue/PR that is related to dependencies packaging Related to packaging/style labels May 16, 2024
@h-mayorquin h-mayorquin self-assigned this May 16, 2024
@samuelgarcia
Copy link
Member

Give me a few days to fix the get_cmap().

@h-mayorquin
Copy link
Collaborator Author

Give me a few days to fix the get_cmap().

A few days have passed.

@alejoe91 @samuelgarcia
Can we merge this? It will cause problems in the school for some people. When you fix it we can just drop the restriction.

@alejoe91
Copy link
Member

ok for me. @samuelgarcia ?

@samuelgarcia
Copy link
Member

Lets merge this very very temporary.

@samuelgarcia samuelgarcia merged commit 9aebd5a into SpikeInterface:main May 21, 2024
11 checks passed
@h-mayorquin
Copy link
Collaborator Author

Yep, for this to be temporary is the main idea.

@h-mayorquin h-mayorquin deleted the limit_matplotlib_dependency branch May 21, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issue/PR that is related to dependencies packaging Related to packaging/style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin version of matplotlib
3 participants