Fix axes generation when num_axes is odd and figure is passed #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samuelgarcia this fixes a bug that was caused by initializing the
axeswithnp.zeros.In case num_axes is odd, we still have to generate all
nrows * ncolsaxes and then remove the excess ones (like it's done when not passing the figure). This bug was triggering an error because in other functions we assume (correctly) that allaxesare mpl axes.We should merge this and release 0.95.1 otherwise the
plot_unit_templatesandplot_unit_waveformsis broken.Note that it worked when num_units is divisible by ncols.