Update README.md (Queue.passive) #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failures aren't being logged? I find that to be intolerable and would prefer to fix them, than to advertise them. A future is returned by the subscription method, the failure to bind is definitely propagated through that. Thanks for the report. I'm going to see about logging the error quickly. |
|
The silent failure is resolved by 9984d72; can you update your pull request? |
No more silent failures.
|
Thanks! Pull request updated. |
timcharper
added a commit
that referenced
this pull request
Dec 15, 2015
Update README.md (Queue.passive)
|
Travis CI is a new thing and looks like there might be a brittle test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#45