order_by in JS client
#121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
============================================
+ Coverage 63.06% 63.29% +0.22%
Complexity 179 179
============================================
Files 78 78
Lines 1814 1828 +14
Branches 37 37
============================================
+ Hits 1144 1157 +13
- Misses 659 660 +1
Partials 11 11 |
|
@armiol, PTAL. |
armiol
approved these changes
Oct 28, 2019
| /** | ||
| * Requests the query results to be ordered by the given `column` in the descending direction. | ||
| * | ||
| * Weather or not the results will be sorted in the given order depends on the implementation |
There was a problem hiding this comment.
Whether the results will be sorted in the requested order depends on the implementation of server-side communication.
| /** | ||
| * Requests the query results to be ordered by the given `column` in the ascending direction. | ||
| * | ||
| * Weather or not the results will be sorted in the given order depends on the implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a missing feature to the JS client. Now we can specify ordering for query response from the JS library.
Note that ordering is neither restored nor verified by the client itself. A server may choose to ignore it completely, or, as is the case with Firebase, the ordering may be lost when transporting data from server to client.
Since the
limitparameter requires presence oforder_by, this feature is vital for users who may want to uselimit, even if strict ordering is not supported.