Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new conclusion state to support flutter autosubmit bot #315

Merged

Conversation

ricardoamador
Copy link
Collaborator

The flutter team needs a new state to support skipping stable tests in presubmit pull requests.

@@ -45,6 +45,7 @@ class CheckRunConclusion extends EnumWithValue {
static const neutral = CheckRunConclusion._('neutral');
static const cancelled = CheckRunConclusion._('cancelled');
static const timedOut = CheckRunConclusion._('timed_out');
static const skipped = CheckRunConclusion._('skipped');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@robrbecker robrbecker added semver:minor Non-Breaking Public API Changes (additions) unreleased labels Jun 23, 2022
@robrbecker
Copy link
Member

Looks good. Let me know if you want it merged or if there's more to add/review on your end.

@ricardoamador
Copy link
Collaborator Author

Hi @robrbecker, can you please merge this when you get a chance? Thank you!

@CaseyHillers CaseyHillers merged commit 1cee939 into SpinlockLabs:master Jun 23, 2022
@ricardoamador ricardoamador deleted the add_skipped_conclusion branch June 23, 2022 16:29
@robrbecker
Copy link
Member

Released in version 9.3.0 https://github.com/SpinlockLabs/github.dart/releases/tag/9.3.0

@CaseyHillers
Copy link
Collaborator

FYI @robrbecker I manually triggered https://github.com/SpinlockLabs/github.dart/actions/workflows/release_unreleased_prs.yml to get this to release. I think the action is misconfigured to run on the forks instead of the upstream, which is causing failures

@CaseyHillers
Copy link
Collaborator

9.3.0 was successfully prepped, but the last step failed with publishing. I think it's a quick upstream fix in the pub publish action in https://github.com/sakebook/actions-flutter-pub-publisher.

I've gone ahead and manually published this @ricardoamador so you should be able to use your changes

@ricardoamador
Copy link
Collaborator Author

Cool! Thank you @CaseyHillers appreciate the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released semver:minor Non-Breaking Public API Changes (additions)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants