New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a new conclusion state to support flutter autosubmit bot #315
Added a new conclusion state to support flutter autosubmit bot #315
Conversation
@@ -45,6 +45,7 @@ class CheckRunConclusion extends EnumWithValue { | |||
static const neutral = CheckRunConclusion._('neutral'); | |||
static const cancelled = CheckRunConclusion._('cancelled'); | |||
static const timedOut = CheckRunConclusion._('timed_out'); | |||
static const skipped = CheckRunConclusion._('skipped'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a test to cover the skipped
case: https://github.com/SpinlockLabs/github.dart/blob/master/test/unit/checks_test.dart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Looks good. Let me know if you want it merged or if there's more to add/review on your end. |
Hi @robrbecker, can you please merge this when you get a chance? Thank you! |
Released in version 9.3.0 https://github.com/SpinlockLabs/github.dart/releases/tag/9.3.0 |
FYI @robrbecker I manually triggered https://github.com/SpinlockLabs/github.dart/actions/workflows/release_unreleased_prs.yml to get this to release. I think the action is misconfigured to run on the forks instead of the upstream, which is causing failures |
9.3.0 was successfully prepped, but the last step failed with publishing. I think it's a quick upstream fix in the pub publish action in https://github.com/sakebook/actions-flutter-pub-publisher. I've gone ahead and manually published this @ricardoamador so you should be able to use your changes |
Cool! Thank you @CaseyHillers appreciate the help. |
The flutter team needs a new state to support skipping stable tests in presubmit pull requests.