Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a new conclusion state to support flutter autosubmit bot #315

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Added a new conclusion state to support flutter autosubmit bot #315

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
328fa41
Added a new conclusion state.
ricardoamador Jun 22, 2022
9f55646
Add a test for the new conclusion state.
ricardoamador Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/src/common/model/checks.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ class CheckRunConclusion extends EnumWithValue {
static const neutral = CheckRunConclusion._('neutral');
static const cancelled = CheckRunConclusion._('cancelled');
static const timedOut = CheckRunConclusion._('timed_out');
static const skipped = CheckRunConclusion._('skipped');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test to cover the skipped case: https://github.com/SpinlockLabs/github.dart/blob/master/test/unit/checks_test.dart.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

static const actionRequired = CheckRunConclusion._('action_required');
static const empty = CheckRunConclusion._(null);

Expand Down