Bug Fix: #550

Splidejs · Dec 3, 2021 · 815030f · 815030f
1 parent 4053202
commit 815030f
Show file tree

Hide file tree

Showing 12 changed files with 21 additions and 25 deletions.
diff --git a/.editorconfig b/.editorconfig
diff --git a/dist/js/splide-renderer.min.js b/dist/js/splide-renderer.min.js
diff --git a/dist/js/splide.cjs.js b/dist/js/splide.cjs.js
@@ -1,6 +1,6 @@
 /*!
  * Splide.js
- * Version  : 3.6.8
+ * Version  : 3.6.9
  * License  : MIT
  * Copyright: 2021 Naotoshi Fujita
  */
@@ -1787,12 +1787,12 @@ function Drag(Splide2, Components2, options) {
       const { noDrag } = options;
       const isTouch = isTouchEvent(e);
       const isDraggable = !noDrag || !matches(e.target, noDrag);
+      clickPrevented = false;
       if (isDraggable && (isTouch || !e.button)) {
         if (!Move.isBusy()) {
           target = isTouch ? track : window;
           prevBaseEvent = null;
           lastEvent = null;
-          clickPrevented = false;
           bind(target, POINTER_MOVE_EVENTS, onPointerMove, SCROLL_LISTENER_OPTIONS);
           bind(target, POINTER_UP_EVENTS, onPointerUp, SCROLL_LISTENER_OPTIONS);
           Move.cancel();

diff --git a/dist/js/splide.esm.js b/dist/js/splide.esm.js
@@ -1,6 +1,6 @@
 /*!
  * Splide.js
- * Version  : 3.6.8
+ * Version  : 3.6.9
  * License  : MIT
  * Copyright: 2021 Naotoshi Fujita
  */
@@ -1783,12 +1783,12 @@ function Drag(Splide2, Components2, options) {
       const { noDrag } = options;
       const isTouch = isTouchEvent(e);
       const isDraggable = !noDrag || !matches(e.target, noDrag);
+      clickPrevented = false;
       if (isDraggable && (isTouch || !e.button)) {
         if (!Move.isBusy()) {
           target = isTouch ? track : window;
           prevBaseEvent = null;
           lastEvent = null;
-          clickPrevented = false;
           bind(target, POINTER_MOVE_EVENTS, onPointerMove, SCROLL_LISTENER_OPTIONS);
           bind(target, POINTER_UP_EVENTS, onPointerUp, SCROLL_LISTENER_OPTIONS);
           Move.cancel();

diff --git a/dist/js/splide.js b/dist/js/splide.js
diff --git a/dist/js/splide.js.map b/dist/js/splide.js.map
diff --git a/dist/js/splide.min.js b/dist/js/splide.min.js
diff --git a/dist/js/splide.min.js.gz b/dist/js/splide.min.js.gz
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@splidejs/splide",
-  "version": "3.6.8",
+  "version": "3.6.9",
   "description": "Splide is a lightweight, flexible and accessible slider/carousel. No dependencies, no Lighthouse errors.",
   "author": "Naotoshi Fujita",
   "license": "MIT",

diff --git a/src/js/components/Drag/Drag.ts b/src/js/components/Drag/Drag.ts
@@ -122,12 +122,13 @@ export function Drag( Splide: Splide, Components: Components, options: Options )
       const isTouch     = isTouchEvent( e );
       const isDraggable = ! noDrag || ! matches( e.target, noDrag );
 
+      clickPrevented = false;
+
       if ( isDraggable && ( isTouch || ! e.button ) ) {
         if ( ! Move.isBusy() ) {
-          target         = isTouch ? track : window;
-          prevBaseEvent  = null;
-          lastEvent      = null;
-          clickPrevented = false;
+          target        = isTouch ? track : window;
+          prevBaseEvent = null;
+          lastEvent     = null;
 
           bind( target, POINTER_MOVE_EVENTS, onPointerMove, SCROLL_LISTENER_OPTIONS );
           bind( target, POINTER_UP_EVENTS, onPointerUp, SCROLL_LISTENER_OPTIONS );

diff --git a/src/js/test/php/examples/default.php b/src/js/test/php/examples/default.php
@@ -53,6 +53,10 @@
       } );
 
       splide.mount();
+
+			// Array.from( document.getElementsByTagName( 'button' ) ).forEach( button => {
+			// 	button.addEventListener( 'click', () => alert( 'click' ) );
+			// } );
     } );
   </script>