Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support plugin versions in version catalog #678

Open
1 task done
reva opened this issue Mar 14, 2023 · 1 comment
Open
1 task done

Support plugin versions in version catalog #678

reva opened this issue Mar 14, 2023 · 1 comment

Comments

@reva
Copy link

reva commented Mar 14, 2023

I'm probably missing something, but just following the docs...:

🐛 Describe the problem

  • Plugin versions in gradle/libs.versions.toml do not get 'refreshed'
  • VersionCatalogOnly still needs a versions.properties file

⚠️ Current behavior

  • When migrating with VersionCatalogOnly the versions.properties is still required
  • When running refreshVersions, the versions for plugins in the gradle/libs.versions.toml do not get comments for the newest versions

✅ Expected behavior

  • VersionCatalogOnly should only use the version catalog, not the version.properties
  • refreshVersions should refresh plugins as well. It does so in the versions.properties but this file is not expected at all (How to avoid generating versions.properties? #640)

💣 Steps to reproduce

@LouisCAD LouisCAD changed the title VersionCatalogOnly mode does not work with plugins Support plugin versions in version catalog Mar 15, 2023
@reva
Copy link
Author

reva commented Mar 17, 2023

Testing a bit further it seemed to me that the plugin always used the versions.properties file, not the actual version catalog. I curated the libs.versions.toml file by hand and switched to version-catalog-update-plugin which works great but for gradle/gradle#22797 (which should soon be fixed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant