Add inv_ready event to signalize when the inventory can be used #135
Conversation
| @@ -144,6 +145,16 @@ def __init__(self, ploader, settings): | |||
| # stores the last click action for confirmation | |||
| self.last_click = None | |||
|
|
|||
| # to know when the inventory got synced with server | |||
| self.is_synchronized = False | |||
There was a problem hiding this comment.
Is there a situation where can is_synchronized can be undefined? Should it be set in the class definition or initializer?
There was a problem hiding this comment.
It should be an instance property, so it should be undefined when no instance (and thus no inventory to be synchronized) exists.
By the way, other plugins cannot access this anyways, as it is in InventoryPlugin, not in InventoryBase.
There was a problem hiding this comment.
Ah sorry, I actually misread the diff and thought it wasn't being set in __init__!
|
Needs a better name than inv_ready, due to the fact we dont really know what the event entails. |
|
I would like @nickelpro to review and merge if he thinks this is good. |
|
Only thing I'm unclear on @Gjum is the condition you're using to signal inventory synchronization. What are the significance of those id constants? I'm sure your behavior is correct I'd just like to understand before I merge |
|
@nickelpro When the server notices that the clients inventory state is wrong, it sends a window items, a set slot for the cursor, and a set slot for every non-empty slot. So by hooking into the cursor set slot, we know that at this point the clients inventory state is correct again. |
Add inv_ready event to signalize when the inventory can be used
A new
inv_readyevent is emitted when the inventory got refreshed by the server, which happens after connection and when a new window is opened or closed.Also sends
inv_open_windowwhen the player's inventory is opened initially.The
inv_open_windowis delayed until all slots of the window are updated, so that a handler does not work with the wrong inventory.Closes #118.