Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

movement.is_moving works, add event 'movement_follow_path_done' #181

Closed
wants to merge 2 commits into from
Closed

movement.is_moving works, add event 'movement_follow_path_done' #181

wants to merge 2 commits into from

Conversation

luken
Copy link
Contributor

@luken luken commented Oct 9, 2015

No description provided.

Gjum
Gjum reviewed Oct 9, 2015
View reviewed changes
spockbot/plugins/helpers/movement.py
is_processing = self.__plug.pathfinding.is_processing()
is_moving = self.__plug.path_nodes is not None
ret = is_moving or is_processing
return ret
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably want to inline ret

@luken luken mentioned this pull request Oct 9, 2015
Closed
@luken luken mentioned this pull request Oct 10, 2015
Closed
@luken
Copy link
Contributor Author

luken commented Oct 20, 2015

Getting old, will resubmit after reworking.

@luken luken closed this Oct 20, 2015
@luken luken deleted the fix_movement.is_moving branch October 20, 2015 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nickelpro nickelpro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luken @Gjum @nickelpro