Feature/flake plugins #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x, left undefined vars unfixed
| @@ -349,7 +348,7 @@ def decode_extra(packet, bbuff): | |||
| def encode_extra(packet): | |||
| bbuff = utils.BoundBuffer() | |||
| if packet.data['nbt'] is None: | |||
| packet.data['nbt'] = nbt._TAG_End() | |||
| packet.data['nbt'] = nbt._TagEnd() | |||
There was a problem hiding this comment.
not sure, but if we change the nbt module, we could as well rename this to TagEnd
There was a problem hiding this comment.
Sure, just wanted to be compliant, supposing you really didn't wanted to make that class available (one underscore is meant for that). Checkout __all__ if that's the case!
There was a problem hiding this comment.
I think it's _ because the code is copied from elsewhere, where it wasn't exposed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now this flake runs with the plugins. I just left those 4 indefinitions