Interact plugin #85
Interact plugin #85
Conversation
Gjum
force-pushed
the
master
branch
2 times, most recently
from
4bd6a69
to
1111bad
Compare
| requires = ('ClientInfo', 'Inventory', 'Net') | ||
|
|
||
| def __init__(self, ploader, settings): | ||
| super().__init__(ploader, settings) |
There was a problem hiding this comment.
Please fix for python 2 support
There was a problem hiding this comment.
Oh, missed that one. Although the CI greenlit it for Python 2.7, interesting.
|
Also can you now add interact plugin to DefaultPlugins |
|
I'm also not sure where all these constants belong. |
| ('event', event.EventPlugin), | ||
| ('net', net.NetPlugin), | ||
| ('auth', auth.AuthPlugin), | ||
| ('ticker', ticker.TickerPlugin), | ||
| ('timers', timer.TimerPlugin), |
There was a problem hiding this comment.
Maybe this should be timer instead of timers? The rest are singular
There was a problem hiding this comment.
Problem is that every plugin requires it with "Timers". This would have to be changed everywhere.
But I agree, keeping it consistent would be better.
There was a problem hiding this comment.
Thats not how that value works, that value is just for the settings dict that gets passed into Client, so that can be changed without much consequence.
There was a problem hiding this comment.
I'd still like it to be the same as in Timer's pl_announce.
Some testing still needs to be done, although I have been using it for some time now (April, wow...).