Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player crafting inventory crash & dupe #3803

Closed
avaruus1 opened this issue Jan 3, 2023 · 0 comments · Fixed by #3804
Closed

Player crafting inventory crash & dupe #3803

avaruus1 opened this issue Jan 3, 2023 · 0 comments · Fixed by #3804
Labels
system: inventory system: phase tracker type: bug Something isn't working version: 1.16 (u) API: 8

Comments

@avaruus1
Copy link
Contributor

avaruus1 commented Jan 3, 2023

Affected Product(s)

SpongeVanilla

Version

1.16.5-8.1.0-RC1246

Operating System

Linux/6.1.1-zen1-1-zen (amd64)

Java Version

18.0.1/64-bit

Plugins/Mods

-

Describe the bug

I've discovered two bugs related to the player crafting inventory.

a. (crash)

  1. Have a plugin that cancels AffectSlotEvent
  2. Place your cursor on the crafting grid and use a number key to move an item from your hotbar to it. (This is cancelled, but for some reason a duplicate of the item is placed in the crafting output slot)
  3. Shift click the item in the output slot. (non-shift click doesn't crash the server)
  4. Server hangs

Crash report

b. (dupe)

  1. Have a plugin cancel CraftItemEvent.Craft
  2. Place a valid recipe in the crafting inventory
  3. Shift clicking is cancelled correctly, but a normal click gives you the output without removing the ingredients

Link to logs

No response
@avaruus1 avaruus1 added status: needs triage This label is automatically applied to new issues and pull requests to indicate they require triage type: bug Something isn't working labels Jan 3, 2023
@aromaa aromaa mentioned this issue Jan 4, 2023
Merged
@aromaa aromaa added system: inventory system: phase tracker version: 1.16 (u) API: 8 and removed status: needs triage This label is automatically applied to new issues and pull requests to indicate they require triage labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
system: inventory system: phase tracker type: bug Something isn't working version: 1.16 (u) API: 8
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix container click events involving player crafting slots aromaa/Sponge
2 participants
@aromaa @avaruus1