Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix container click events involving player crafting slots #3804

Merged
merged 1 commit into from Jan 8, 2023

Conversation

aromaa
Copy link
Member

@aromaa aromaa commented Jan 4, 2023

Adding ingredients that do not have crafting recipe would result in transactions where the first ingredient would be seen as the output.

Cancelling event like CraftItemEvent.Craft would not take in to account whatever the event got cancelled and not just the cursor transaction.

Fixes #3803

@zml2008 zml2008 requested a review from Faithcaio January 7, 2023 04:33
@Zidane Zidane merged commit f7c5fe7 into SpongePowered:api-8 Jan 8, 2023
@aromaa aromaa deleted the fix/crafting-transactions branch January 8, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Player crafting inventory crash & dupe
2 participants