Implement ChangeValueEvent #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istration should work, but now to actually throw said events based on keys... Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
No but seriously.... this is working for entity flags, which represents Keys.IS_SNEAKING, Keys.IS_SPRINTING, Keys.INVISIBLE, and Keys.GLOWING. The nice thing is that this should be the fastest we can churn out events in this circumstance. Some testing still has to flow through to get some potion effects handled correctly, since setting glowing on entities does not get tracked through commands properly because it is applying an effect, instead of setting the flag itself. Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
|
I agree with @kashike here. That is hard to see what is happening. |
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
…anges, now at this point it is purely implementation, and not API. Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
liach
reviewed
Dec 31, 2017
|
|
||
| @Override | ||
| public String getValueFromEvent(String originalValue, List<ImmutableValue<?>> immutableValues) { | ||
| return null; |
This was referenced Jan 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpongeAPI | SpongeCommon
This sets up the system for implementing
ChangeValueEventif only for Entities at present time.TileEntityinstances are a little different to handle as there is no data sync system short of serializing theTileEntityand sending it over the wire.