Skip to content

Allow the Registration of EventListeners for Keys#1728

Merged
gabizou merged 1 commit into
bleedingfrom
feature/change-value-event
Dec 30, 2017
Merged

Allow the Registration of EventListeners for Keys#1728
gabizou merged 1 commit into
bleedingfrom
feature/change-value-event

Conversation

@gabizou

@gabizou gabizou commented Dec 28, 2017

Copy link
Copy Markdown
Member

SpongeAPI | SpongeCommon
This is to supersede #1695 in some aspects to make it more functional to allow plugins to isolate specific key event listeners. The implementation of the event is also directing the flow of this being used.

…egistration for ChangeValueEvent implementation.

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
@Cybermaxke

Copy link
Copy Markdown
Contributor

Could the ChangeDataHolderEvent be renamed to just DataHolderEvent and get a generic type H which represents the holder type of the event. The event can extend GenericEvent later when it is implemented, but the generic holder type is still useful because you don't need the generic event when registering the listener in the Key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants