Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement .entities and add test plugin #3520

Closed
wants to merge 3 commits into from
Closed

Implement .entities and add test plugin #3520

wants to merge 3 commits into from

Conversation

tyhdefu
Copy link
Contributor

@tyhdefu tyhdefu commented Sep 4, 2021 •
edited
Loading

SpongeAPI | Sponge

I have added a test plugin that does basic automatic checks, and have also checked that the entities displayed in console during the test line up with the entities in the game.

@tyhdefu tyhdefu mentioned this pull request Sep 4, 2021
Closed
@tyhdefu tyhdefu force-pushed the add-entities-method-to-entity-volume branch from cefbcb5 to b29091b Compare September 9, 2021 20:17
@tyhdefu
Copy link
Contributor Author

tyhdefu commented Sep 10, 2021

This is ready for merge and has the latest test plugin json changes now.

@tyhdefu tyhdefu force-pushed the add-entities-method-to-entity-volume branch 2 times, most recently from 817538b to e525233 Compare September 16, 2021 16:09
@tyhdefu
Implement .entities and add test plugin
2649f63 
Add license to the test plugin

Move injects to constructor, and prefix shadowed method

update SpongeAPI

Test plugin for move of @plugin annotation

Add @OverRide and remove implementation from Level

Remove extra space

Don't add useless @shadow

Remove unused import
@tyhdefu tyhdefu force-pushed the add-entities-method-to-entity-volume branch from e525233 to 2649f63 Compare September 16, 2021 16:12
dualspiral
dualspiral reviewed Oct 9, 2021
View reviewed changes
Copy link
Contributor

@dualspiral dualspiral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks okay, though there is an interesting point here.

(Also, sorry it's been a little bit of time)

...java/org/spongepowered/common/world/volume/buffer/entity/ObjectArrayMutableEntityBuffer.java Outdated Show resolved Hide resolved
...va/org/spongepowered/common/mixin/api/minecraft/client/multiplayer/ClientLevelMixin_API.java Outdated Show resolved Hide resolved
@dualspiral
Copy link
Contributor

0852eb1

@dualspiral dualspiral closed this Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dualspiral dualspiral dualspiral left review comments

@gabizou gabizou gabizou requested changes

Assignees
No one assigned
Labels
version: 1.16 (u) API: 8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tyhdefu @dualspiral @gabizou