Inventory properties #995
Closed
Inventory properties #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faithcaio
force-pushed
the
feature/inventory-properties
branch
from
b4dda93
to
699acce
Compare
Faithcaio
force-pushed
the
feature/inventory-properties
branch
from
699acce
to
8ac8715
Compare
Faithcaio
force-pushed
the
feature/inventory-properties
branch
from
8ac8715
to
4f5cac1
Compare
Faithcaio
force-pushed
the
feature/inventory-properties
branch
2 times, most recently
from
0efc6e6
to
3faf5e8
Compare
Faithcaio
force-pushed
the
feature/inventory-properties
branch
2 times, most recently
from
fc497c5
to
979cf11
Compare
Faithcaio
force-pushed
the
feature/inventory-properties
branch
from
979cf11
to
66a4365
Compare
|
Is there any status in this? |
bloodmc
added a commit
that referenced
this pull request
Feb 6, 2017
* Change keepSpawnLoaded, generateSpawnOnLoad, and loadOnStartup to Boolean's to determine when nothing is set. * Move PlayerChunkMap chunk unload queue with no players to start of server tick. This avoids chunks from unloading when requested before PlayerChunkMap tick. * Always allow chunks to load when requested from getTileEntity. This fixes issues with mods such as RFToolsDimensions that check for a specific TE to perform logic. * Remove unregisterable dimension code as it breaks Forge. * Fix wrong foldername being used for hot-loaded dimensions. Fixes #910, Fixes #920, Fixes #995, Fixes #1046 Fixes #1109, Fixes #1117, Fixes #1153
Faithcaio
force-pushed
the
feature/inventory-properties
branch
2 times, most recently
from
ec87646
to
2b82d9a
Compare
Faithcaio
force-pushed
the
feature/inventory-properties
branch
from
2b82d9a
to
2caf268
Compare
Faithcaio
force-pushed
the
feature/inventory-properties
branch
2 times, most recently
from
1709245
to
0ac3bad
Compare
…ntainers implement retrieving InventoryTitle Property from Container/IInventory
Faithcaio
force-pushed
the
feature/inventory-properties
branch
from
0ac3bad
to
ada6623
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inventory Properties were not available.
This PR currently implements the getProperty/ies methods in the base interface
MinecraftInventoryAdapterfor Adapters and CustomInventories.Questions:
(like InventoryTitle)
It's only used with lowercased classname anyway (which is default in currently all InventoryProperties)
Inventory.Builder#property(name, property)remove name in API?