Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PotionEffect duration unit JavaDocs #1269

Closed
randombyte-developer opened this issue Jun 12, 2016 · 0 comments
Closed

PotionEffect duration unit JavaDocs #1269

randombyte-developer opened this issue Jun 12, 2016 · 0 comments
Labels
type: documentation

Comments

@randombyte-developer
Copy link

randombyte-developer commented Jun 12, 2016 •
edited
Loading

To construct a PotionEffect you have to give the duration of the effect. Here in the builder, here in the factory(?) method and here another occurrence. The docs for these methods don't state what unit is used for the duration. Here I learned that the unit is ticks. This should be stated in the docs.
@ghost ghost mentioned this issue Feb 11, 2017
Merged
5 tasks
parlough added a commit to parlough/SpongeAPI that referenced this issue Nov 7, 2017
@parlough
Specifies the unit of potion effect duration, fixes SpongePowered#1269
4503551
parlough added a commit to parlough/SpongeAPI that referenced this issue Nov 7, 2017
@parlough
Specifies the unit of potion effect duration, fixes SpongePowered#1269
096fc3b
@parlough parlough mentioned this issue Nov 7, 2017
Merged
kashike pushed a commit that referenced this issue Nov 10, 2017
Merge pull request #1683 from Meronat/fix/potion-effect-duration-java…
ca4b0bf 
…docs

Specifies the unit of potion effect duration, fixes #1269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Aaron1011 @randombyte-developer