Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

Usage of GetCollisionBoxesEvent breaks Teleportation #2355

Closed
Bucky420 opened this issue Aug 1, 2018 · 19 comments
Closed

Usage of GetCollisionBoxesEvent breaks Teleportation #2355

Bucky420 opened this issue Aug 1, 2018 · 19 comments

Comments

@Bucky420
Copy link

Bucky420 commented Aug 1, 2018

Minecraft: 1.12.2
SpongeAPI: 7.1.0-SNAPSHOT-7105dfc
SpongeForge: 1.12.2-2705-7.1.0-BETA-3361
Minecraft Forge: 14.23.4.2732

Nucleus version 1.4.6-S7.0 (built from commit cb28285)
going to the nether and using using /tp or /spawn i get
Unexpected error running this command: Intended to track block entity spawns! Please analyze the current phase context.

u then must relog to do any thing

the console has a huge error

https://gist.github.com/codydbgt/53c550162257e11a2467623d34c464a0

this does not happen on build 3350 of sponge

NucleusPowered/Nucleus#1231

@limbo-app limbo-app added status: needs triage This label is automatically applied to new issues and pull requests to indicate they require triage version: 1.12 API 7 labels Aug 1, 2018
@limbo-app limbo-app removed the status: needs triage This label is automatically applied to new issues and pull requests to indicate they require triage label Aug 2, 2018
@ryantheleach
Copy link
Contributor

ryantheleach commented Aug 2, 2018

This seems to be a mod incompatibility issue with fairylights, something in our phase tracker might be being incorrectly triggered .

Remapped Trace:

Stacktrace:                                                                                                                                        
 java.lang.IllegalStateException: Intended to track block entity spawns! Please analyze the current phase context.                                  
     org.spongepowered.common.event.tracking.TrackingUtil.lambda$throwWithContext$3(TrackingUtil.java:446)                                          
     org.spongepowered.common.event.tracking.PhaseContext.getPerBlockEntitySpawnSuppplier(PhaseContext.java:452)                                    
     net.minecraft.world.WorldServer.getEntitiesWithinAABB(WorldServer.java:3085)                                                                   
     net.minecraft.world.World.getEntitiesWithinAABB(World.java:3060)                                                                               
     com.pau101.fairylights.server.ServerEventHandler.onGetCollisionBoxes(ServerEventHandler.java:79)                                               
     net.minecraftforge.fml.common.eventhandler.ASMEventHandler_1108_ServerEventHandler_onGetCollisionBoxes_GetCollisionBoxesEvent.invoke(.dynamic) 
     net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)                                                     
     net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:682)                                                                    
     net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:639)                                                                    
     net.minecraft.world.World.getCollisionBoxes(World.java:1387)                                                                                   
     org.spongepowered.common.entity.EntityUtil.changeWorld(EntityUtil.java:889)     

Full Trace:
https://gist.github.com/ryantheleach/489cf1b615993196a405de4f6ab6a89a

@Bucky420
Copy link
Author

Bucky420 commented Aug 3, 2018

i removed that mod and i still have issues

@dualspiral
Copy link
Contributor

Logs showing these issues? We can’t diagnose the problem without them.

@Bucky420
Copy link
Author

Bucky420 commented Aug 3, 2018

will do boss

@Addalyn
Copy link

Addalyn commented Aug 6, 2018

We have the same issues on 2 servers (atm3 and Foolcraft3) this is log from atm3
https://paste.dimdev.org/ewojunubek.md

@PurpleIsEverything
Copy link

Having the same issue here on a Foolcraft server.

@Bucky420
Copy link
Author

Bucky420 commented Aug 9, 2018

is this good?
latest.log

java.lang.IllegalStateException: Intended to track block entity spawns! Please analyze the current phase context.                      */
[07:36:21] [Server thread/ERROR] [Sponge]: /*     org.spongepowered.common.event.tracking.TrackingUtil.lambda$throwWithContext$3(TrackingUtil.java:446)                              */
[07:36:21] [Server thread/ERROR] [Sponge]: /*     org.spongepowered.common.event.tracking.PhaseContext.getPerBlockEntitySpawnSuppplier(PhaseContext.java:452)                        */
[07:36:21] [Server thread/ERROR] [Sponge]: /*     net.minecraft.world.WorldServer.func_175647_a(WorldServer.java:3079)                                                               */
[07:36:21] [Server thread/ERROR] [Sponge]: /*     net.minecraft.world.World.func_72872_a(World.java:3060)                                                                            */
[07:36:21] [Server thread/ERROR] [Sponge]: /*     com.creativemd.littletiles.common.events.LittleEvent.worldCollision(LittleEvent.java:458)                                          */
[07:36:21] [Server thread/ERROR] [Sponge]: /*     net.minecraftforge.fml.common.eventhandler.ASMEventHandler_1079_LittleEvent_worldCollision_GetCollisionBoxesEvent.invoke(.dynamic) */
[07:36:21] [Server thread/ERROR] [Sponge]: /*     net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)                                         */
[07:36:21] [Server thread/ERROR] [Sponge]: /*     net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:682)                                                        */
[07:36:21] [Server thread/ERROR] [Sponge]: /*     net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:639)                                                        */
[07:36:21] [Server thread/ERROR] [Sponge]: /*     net.minecraft.world.World.func_184144_a(World.java:1387)                                                                           */
[07:36:21] [Server thread/ERROR] [Sponge]: /*     org.spongepowered.common.entity.EntityUtil.changeWorld(EntityUtil.java:889)                                                        */
[07:36:21] [Server thread/ERROR] [Sponge]: /*     net.minecraft.entity.Entity.setLocation(Entity.java:5356)                                                                          */
[07:36:21] [Server thread/ERROR] [Sponge]: /*     net.minecraft.entity.Entity.setLocationAndRotation(Entity.java:5303)           

i can remove littletiles but that does no world stuff either its a block mod XD
i also did test with version 3376 of sponge

@cuddylier
Copy link

I can confirm I also face this issue with any Forge version above 3350 and it also disappears with Sponge 3350.

Logs:

https://pastebin.com/raw/qv1HwYT5
https://pastebin.com/raw/qnZtXCAa

@rvveber
Copy link

rvveber commented Aug 23, 2018

Same or Similar Issue.

I am currently running

  • SpongeForge version: 3413
  • Forge version: forge-1.12.2-14.23.4.2756

Plugins:
nucleus, luckperms, totaleconomy etc. (others not relevant)

Issue Description
https://www.youtube.com/watch?v=pLPWPFAbTPM&feature=youtu.be

log
https://ghostbin.com/paste/w7q2d

And i highly doubt it's mod incompatibility

@Shybella
Copy link

Shybella commented Aug 23, 2018

Other plugins/mods are relevant if you read this topic you will see that

Disable LittleTiles and see what happens. I am not experiencing this problem.

I'm assuming your home location is ontop of LittleTiles.

LXGaming added a commit to LXGaming/Sledgehammer that referenced this issue Aug 25, 2018
Rename SpongeIntegration -> SpongeIntegration_Death
@selkiess
Copy link

selkiess commented Oct 4, 2018

I also ran into this when running a All the mods 3 v5.10.1 server.

I can also confirm that reverting to spongeforge build 3350 fixes the problem.

Relevant log:
log.txt

@rvveber
Copy link

rvveber commented Oct 4, 2018 via email

@selkiess
Copy link

selkiess commented Oct 4, 2018

I looked up the modlist for ATM3 but it looks like little tiles is not included in this modpack:
https://rawgit.com/AllTheMods/ATM-3/master/modlist.html

@phit
Copy link
Contributor

phit commented Oct 4, 2018

@Selkie707 fairy lights is, this happens when either fairylights or little tiles is on the server

@selkiess
Copy link

selkiess commented Oct 5, 2018

@phit Is the problem on sponges end then or fairylights/little tiles?

I see that the issue was referenced Here by fairylights but that dev said there was nothing he could do and it was on Sponge's end.

@selkiess
Copy link

Not sure if this will help fix the bug but I did just have something odd happen. I was testing the latest build 3481 to see if it was fixed and it was not, was in the nether and doing /spawn would just tp me to the nethers spawn, /home would bug as well.

Relevant Bit: I disconnected with myself still in the nether and downgraded spongeforge back to 3350, When I logged in I was now in the overworld near 0,0. No idea if this will help but it was definitely odd.

Since we know the problem started after 3350, could the problem be caused by all the changes in 49e9304 for 3351. I see a bunch of things were added/changed for phase tracker/context

@phit phit added this to todo in phit's eternal cleanup Dec 29, 2018
@phit phit added the type: bug Something isn't working label Jan 2, 2019
@phit phit moved this from todo to tested in phit's eternal cleanup Jan 2, 2019
@phit phit changed the title cant tp or /spawn Usage of GetCollisionBoxesEvent breaks Teleportation Jan 2, 2019
@phit
Copy link
Contributor

phit commented Jan 2, 2019

somehow calling anything with AABB inside the GetCollisionBoxesEvent causes this to happen

repro:
install fairy lights and nucleus
be in overworld and do /spawn DIM1

https://github.com/pau101/Fairy-Lights/blob/1.12/src/main/java/com/pau101/fairylights/server/ServerEventHandler.java#L79

@RainOfPain125
Copy link

Happening since aug 1 and no fixes?

subbing to this thread

gabizou added a commit that referenced this issue Jan 24, 2019
…so wrapped in phase contexts when possible.

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
ImMorpheus pushed a commit to ImMorpheus/SpongeForge that referenced this issue Jan 25, 2019
…teners are also wrapped in phase contexts when possible.

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
ImMorpheus pushed a commit to ImMorpheus/SpongeCommon that referenced this issue Feb 8, 2019
…e disabled. Fixes SpongePowered/SpongeForge#2355.

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
@ihavelag
Copy link

Is there any plan to fix this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
phit's eternal cleanup
  
tested/closed
Development

No branches or pull requests