Fix #26: split ConstantCollector into two classes #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danglotb
commented
Oct 4, 2016
| * Created by bdanglot on 10/4/16. | ||
| */ | ||
| public class DefaultConstantCollector extends AbstractProcessor<CtLiteral> { | ||
|
|
There was a problem hiding this comment.
This class has no impact on the state of the program (contain only some checks and return statement). We should just remove it IMHO.
There was a problem hiding this comment.
We collect all literals by default also in SMT mode.
danglotb
force-pushed
the
constant-collector
branch
from
b4aa50f
to
6e160c3
Compare
monperrus
reviewed
Oct 6, 2016
|
|
||
| @Override | ||
| public boolean isToBeProcessed(CtLiteral candidate) { | ||
| CtMethod parent = candidate.getParent(CtMethod.class); |
There was a problem hiding this comment.
we don't care about the parent, remove the tests
monperrus
reviewed
Oct 6, 2016
| if (candidate.getValue() instanceof Boolean) { | ||
| return false; | ||
| } else if (candidate.getValue() instanceof Number) {// 3 defaults value will be added anyway | ||
| if (candidate.getValue().equals(1) || |
…onstant-collector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.