Fix #35: consitency spec and logs #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monperrus
reviewed
Oct 6, 2016
| } | ||
|
|
||
| if (output.equals(reference) && this.keys.equals(inputs.keySet())) { | ||
| this.logger.warn("You may have some redundant test: same input and same outcome, only one will be used: discarded.");// case 3 |
There was a problem hiding this comment.
in each log line can you add the specification as well?
monperrus
reviewed
Oct 6, 2016
| // we discard it | ||
| this.inconsistentInputs.add(inputs); | ||
| if (!this.keys.equals(inputs.keySet())) { | ||
| this.logger.debug("Malformed problems: the same input value has different outcome: discarded.");// case 2 |
There was a problem hiding this comment.
Message should be "Ill-formed problem: not the input variables in "+inputs +" reference ("+keys+")"
monperrus
reviewed
Oct 6, 2016
| this.logger.debug("Malformed problems: the same input value has different outcome: discarded.");// case 2 | ||
| consistentInputs().remove(inputs); | ||
| } else { | ||
| this.logger.debug("Inconsistent specification: same input with same outcome, the condition can be flipped with no impact: discarded.");// case 1 |
There was a problem hiding this comment.
same input with different outcome, logical contradiction, discarding the second one.
monperrus
reviewed
Oct 6, 2016
| @@ -67,7 +67,8 @@ private void addToSpec(Map<String, Object> inputs, T output) { | |||
| } | |||
|
|
|||
| if (output.equals(reference) && this.keys.equals(inputs.keySet())) { | |||
| this.logger.warn("You may have some redundant test: same input and same outcome, only one will be used: discarded.");// case 3 | |||
There was a problem hiding this comment.
you have redundant tests: same input and same outcome, only one will be used to speed-up synthesis
|
the new tests are really good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement of the consistency specifications management. We identify 3 cases:
For each case, a log has been added.
More over, with the fix of consistency, NoPol is able to find a patch for median_90a14c1a from IntroClassJava while it could not before.