Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added enableComments as option to the maven build #41

Merged
merged 5 commits into from
Jun 19, 2017

Conversation

boegemann
Copy link
Contributor

I added the existing command line '--enable-comments' options as a configuration parameter to the Maven plugin. I left the default as false to keep behaviour.
To enable comments just set the enableComments property to true inside the plugin configuration:

  <plugin>
    <groupId>fr.inria.gforge.spoon</groupId>
    <artifactId>spoon-maven-plugin</artifactId>
    <configuration>
    	<enableComments>true</enableComments>
    </configuration>
  </plugin>

@surli
Copy link
Collaborator

surli commented Jun 19, 2017

Hi! Thanks for your PR, the feature is interesting! However it appears you used Windows-style end of lines in the files you changed, which messes up the diff in the PR.
Could you put back linux-style end of lines please?

@boegemann
Copy link
Contributor Author

Thanks for the feedback. Line endings should have changed now.

@@ -0,0 +1,2 @@
* text eol=crlf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this line is useless.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second line specifies the local method for line endings as opposed to the method used in the repository. Feel free to remove or to change to auto or ignore the file fully. Just used it to get the other files in line with your preferred style.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree for the second one, but it overrides the first one, which is then useless... I'm not sure why you keep both in this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to an Stack overflow the first one defines Server side and the second one client side.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that it's correct: it's specified in Git documentation:

When more than one pattern matches the path, a later line overrides an earlier line. This overriding is done per attribute.

Source: https://git-scm.com/docs/gitattributes

Nevertheless I'll accept the PR and fix that after ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers and thanks - great Project btw!

@surli surli merged commit 3c7ab68 into SpoonLabs:master Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants