🐛 Fix bugs related to fetchmany and pagination #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsthejoker
added
the
bump-minor-version
github-actions
bot
removed
the
bump-minor-version
szymonhab
reviewed
Apr 6, 2023
szymonhab
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #31
Description:
When
fetchmany()is called but there's no matching query, it explodes with a very unhelpful error. This PR fixes:fetchmany()not returning default response on no queryfetchall()not returning default response on no queryfetchmany()not returning override responsefetchall()not returning override responsefetchall()now returns a list by defaultfetchmany()now returns a list by default...and adds a bunch of tests!
Checklist: