Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): [security] bump devise from 4.5.0 to 4.6.2 #112

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps devise from 4.5.0 to 4.6.2. This update includes security fixes.

Vulnerabilities fixed

Sourced from The Ruby Advisory Database.

Devise Gem for Ruby Time-of-check Time-of-use race condition with lockable module
Devise ruby gem before 4.6.0 when the lockable module is used is vulnerable to a
time-of-check time-of-use (TOCTOU) race condition due to increment_failed_attempts
within the Devise::Models::Lockable class not being concurrency safe.

Patched versions: >= 4.6.0
Unaffected versions: none

Changelog

Sourced from devise's changelog.

4.6.2 - 2019-03-26

4.6.1 - 2019-02-11

  • bug fixes
    • Check if root_path is defined with #respond_to? instead of #present (by @​tegon)

4.6.0 - 2019-02-07

  • enhancements

    • Allow to skip email and password change notifications (by @​iorme1)
    • Include the use of nil for allow_unconfirmed_access_for in the docs (by @​joaumg)
    • Ignore useless files into the .gem file (by @​huacnlee)
    • Explain the code that prevents enumeration attacks inside Devise::Strategies::DatabaseAuthenticatable (by @​tegon)
    • Refactor the devise_error_messages! helper to render a partial (by @​prograhamer)
    • Add an option (Devise.sign_in_after_change_password) to not automatically sign in a user after changing a password (by @​knjko)
  • bug fixes

    • Fix missing comma in Simple Form generator (by @​colinross)
    • Fix error with migration generator in Rails 6 (by @​oystersauce8)
    • Set encrypted_password to nil when password is set to nil (by @​sivagollapalli)
    • Consider whether the request supports flash messages inside Devise::Controllers::Helpers#is_flashing_format? (by @​colinross)
    • Fix typo inside Devise::Generators::ControllersGenerator (by @​kopylovvlad)
    • Sanitize parameters inside Devise::Models::Authenticatable#find_or_initialize_with_errors (by @​rlue)
    • #after_database_authentication callback was not called after authentication on password reset (by @​kanmaniselvan)
    • Fix corner case when #confirmation_period_valid? was called at the same second as confirmation_sent_at was set. Mostly true for date types that only have second precisions. (by @​stanhu)
    • Fix unclosed li tag in error_messages partial (by @​mracos)
    • Fix Routes issue when devise engine is mounted in another engine on Rails versions lower than 5.1 (by @​a-barbieri)
    • Make #increment_failed_attempts concurrency safe (by @​tegon)
    • Apply Test Helper fix to Rails 6.0 as well as 5.x (by @​matthewrudy)
  • deprecations

    • The second argument of DatabaseAuthenticatable's #update_with_password and #update_without_password is deprecated and will be removed in the next major version. It was added to support a feature deprecated in Rails 4, so you can safely remove it from your code. (by @​ihatov08)
    • The DeviseHelper.devise_error_messages! is deprecated and will be removed in the next major version. Use the devise/shared/error_messages partial instead. (by @​mracos)
Commits
  • 2e5b5fc Prepare for 4.6.2 release
  • 241e807 Update CHANGELOG.md [ci skip]
  • 55e726e Merge pull request #5051 from plataformatec/mf-revert-update-encrypted-passwo...
  • f9d13f0 Revert "[#4245] Allowing password to nil (#4261)"
  • e704221 Revert "Add more tests (#4970)"
  • 2a6d608 Merge pull request #5050 from softwaregravy/patch-1
  • b2dc388 Fix dead link
  • 214ce91 Merge pull request #5045 from matheusbn/small-text-fix-in-strategies/authenti...
  • a460d79 fix text redundancy
  • 2f3a596 Added mention of API mode complications to README (#5041) [ci skip]
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

Bumps [devise](https://github.com/plataformatec/devise) from 4.5.0 to 4.6.2. **This update includes security fixes.**
- [Release notes](https://github.com/plataformatec/devise/releases)
- [Changelog](https://github.com/plataformatec/devise/blob/master/CHANGELOG.md)
- [Commits](heartcombo/devise@v4.5.0...v4.6.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Dependencies need updating security This is very important and could compromise security labels Mar 27, 2019
@coveralls
Copy link

coveralls commented Mar 27, 2019

Pull Request Test Coverage Report for Build 486

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.667%

Totals Coverage Status
Change from base Build 412: 0.0%
Covered Lines: 13
Relevant Lines: 15

💛 - Coveralls

@dependabot-preview
Copy link
Contributor Author

Superseded by #158.

@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/develop/devise-4.6.2 branch September 10, 2019 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies need updating security This is very important and could compromise security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants