Feature award trigger interface #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…what you actually need to put down. Maybe give tooltips or something on hover of these labels
…t we are releasing a new minor version
…emoving the trigger descriptor class. I called the fact that there was way too much abstraction happening. After not looking at this code for about a good 3 or 4 months I couldn't really understand why I needed such a lame class. That, and the fact that I was basically forcing my trigger string to have an unneded "key" really made me mad. So, I removed the key, which takes away the need to even parse that part of the string. Now the trigger descriptor is just a single value that doesn't need to be handled by any resource other than the trigger, which is where it should be.
…g out the test logic. The three types of listener functionality we were testing were on whether or not the listener could give awards based on whether user meta was assigned, created, or updated on a user. We have separated this out into three specific files that allow us to add tests that more specifically go towards this functionality.
…value in our trigger operator
Merging in a fix for issue #3 by adding in tests to check that this behavior does not occur again. Fixing the issue by using the `is_numeric()` php function in `UserAwards\Grammar\Trigger.php` file.
Revert "Issue 3 "
… is supposed to be a value of zero.
Revert "Revert "Issue 3 ""
|
Issue #8 now has to be fixed before we can continue |
In order to have a defined set of constants for use on the front end of the admin page, I needed to build more constants. These are located in constants.php. MetaBoxes plugin logic uses these constants in order to build up the interface used for our award triggers.
|
Issue #9 should be fixed as well. Pretty big bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should introduce a much more user friendly interface to building the trigger string for an award in the New/Update Award pages that are available on the admin area of this plugin.
Should also provide some unit tests that make sure awards are being assigned when we use the interface.