New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config deserializer crate #234
Conversation
remove Default for SpringConfig
Codecov ReportBase: 84.11% // Head: 84.17% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
+ Coverage 84.11% 84.17% +0.05%
==========================================
Files 219 220 +1
Lines 12789 12854 +65
==========================================
+ Hits 10758 10820 +62
- Misses 2031 2034 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kazuk Could you check this patch?
This is nearly what I said in the previous comment.
This patch reduces lots of WET codes.
However, springql-core depends on TOML library, which is the very reason of your work.
So could you consider making toml
feature in springql-configloader
crate, as I said in the previous comment?
I'll take over this PR. |
Issue number and link
Fixes: #220
Recreate for #216
Describe your changes
Checklist before requesting a review
## [Unreleased]
section inCHANGELOG.md
following keep a changelog syntax (bugfix/feature)