Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic by upstream not found #86

Merged
merged 8 commits into from
Apr 7, 2022
Merged

Conversation

laysakura
Copy link
Contributor

@laysakura laysakura commented Apr 7, 2022

Fixes: #80

input_queue() takes task_id and upstream parameters.

These parameters come from different threads:

  • task_id is from GenericWorkerThread
  • upstream is from main thread (when creating CollectSubtask)

These threads may observe different PipelineVersion.

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #86 (34ac2f4) into main (848028c) will decrease coverage by 0.01%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   83.70%   83.68%   -0.02%     
==========================================
  Files         198      198              
  Lines       11769    11770       +1     
==========================================
- Hits         9851     9850       -1     
- Misses       1918     1920       +2     
Impacted Files Coverage Δ
...tream_engine/autonomous_executor/task/sink_task.rs 96.20% <75.00%> (-1.24%) ⬇️
...task/pump_subtask/query_subtask/collect_subtask.rs 98.46% <100.00%> (+0.02%) ⬆️
...rc/stream_engine/autonomous_executor/task_graph.rs 99.43% <100.00%> (-0.01%) ⬇️
...omous_executor/row/value/sql_value/nn_sql_value.rs 66.48% <0.00%> (-0.55%) ⬇️
...ngql-core/tests/feat_performance_metrics_report.rs 99.34% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 848028c...34ac2f4. Read the comment docs.

@laysakura laysakura marked this pull request as ready for review April 7, 2022 07:06
@laysakura laysakura merged commit 26031ab into main Apr 7, 2022
@laysakura laysakura deleted the fix/upstream-stream-not-found branch April 7, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: task id Pump { id: "pu_join", input_type: Window } does not have upstream source_city_temperature
1 participant