Working around String.substring(…) issue introduced in Java7u6 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The String.substring(…) method seems to have become significantly slower on the latest Java7 updates so that we see performance degradation by a factor of 100-1000 in ResourceDatabasePopulator, especially for large SQL files processed. I've worked around this by minimizing the substring scope to the least amount possible to prevent unnecessary internal copying of String (which seems to cause the issue). See http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-May/010257.html Issue: SPR-9781
ghost
assigned 
|
Thanks, Ollie. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The String.substring(…) method seems to have become significantly slower
on the latest Java7 updates so that we see performance degradation by a
factor of 100-1000 in ResourceDatabasePopulator, especially for large SQL
files processed. I've worked around this by minimizing the substring
scope to the least amount possible to prevent unnecessary internal
copying of String (which seems to cause the issue).
See http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-May/010257.html
Issue: SPR-9781