Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of JacksonObjectMapperBeanFactory (SPR-9125). #40

Closed
wants to merge 7 commits into from

Conversation

dmak
Copy link
Contributor

@dmak dmak commented Feb 15, 2012

For more details see https://jira.springsource.org/browse/SPR-9125 and https://jira.springsource.org/browse/SPR-9130

Sample usage (from JavaDocs):

 <mvc:annotation-driven>
    <mvc:message-converters>
        <bean class="org.springframework.http.converter.json.MappingJacksonHttpMessageConverter">
            <property name="objectMapper">
                <bean class="org.springframework.web.context.support.JacksonObjectMapperBeanFactory"
                    p:autoDetectFields="false"
                    p:autoDetectGettersSetters="false"
                    p:annotationIntrospector-ref="jaxbAnnotationIntrospector" />
            </property>
        </bean>
    </mvc:message-converters>
 </mvc:annotation-driven>

For EasyMock:

 <bean name="myService" class="org.springframework.test.context.support.EasyMockBeanFactory"
    p:mockInterface="org.company.api.MyService"
 />

 <bean name="myDao" class="org.springframework.test.context.support.EasyMockBeanFactory"
    p:mockInterface="org.company.api.Dao"
    p:mocksControl-ref="mocksCtrl"
 />

Feedback is welcomed.

@cbeams
Copy link
Contributor

cbeams commented May 16, 2012

Hi Dimitry,

Thanks for the submission!

We're just gearing up for the 3.2 M1 release, and at least with regard to the JacksonObjectMapperFactoryBean, we'd like to see about getting this into the framework.

Could you read and follow the contributor guidelines? The first thing to do would be separating these into two separate pull requests -- you can see the rest of the details in the doc.

Thanks again!

@dmak
Copy link
Contributor Author

dmak commented May 18, 2012

Hi Chris!

I am newbie with Git -- sorry I if I've done it wrong. Will it be OK if I fork your Spring repo, and then I will create two branches (one per issue), commit + pull to you?

@cbeams
Copy link
Contributor

cbeams commented May 18, 2012

No problem. You've already forked SpringSource/spring-framework, so you're good there.

  • Just update to the latest from SpringSource/spring-framework
  • create two branches called SPR-9125 and SPR-9130
  • cherry-pick, rebase, etc your changes for each of these issues onto their specific branches.
  • make sure you follow the contributor guidelines with regard to commit comments, style, and everything else.
  • issue two pull requests, one for each branch.

Git can indeed be a bit tricky at first, but it's worth the effort! Thanks!

@dmak dmak closed this Jun 5, 2012
@dmak
Copy link
Contributor Author

dmak commented Jun 5, 2012

I have created new pull requests:

Thus this pull request can be discarded.

BTW in addition to Contributor guidelines I have found Code conventions useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants